Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AIP-124 – Ensure resource references are valid. #574

Merged
merged 3 commits into from
Jun 27, 2020
Merged

feat: AIP-124 – Ensure resource references are valid. #574

merged 3 commits into from
Jun 27, 2020

Conversation

lukesneeringer
Copy link
Contributor

No description provided.

@lukesneeringer lukesneeringer requested a review from a team June 24, 2020 22:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2020
noahdietz
noahdietz approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after one comment is addressed

rules/aip0124/valid_reference.go Show resolved Hide resolved
Luke Sneeringer and others added 2 commits June 27, 2020 01:14
Merge branch 'master' into valid-ref
cf8d061
@noahdietz
Incorporate @noahdietz feedback.
8049a5e 
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
@lukesneeringer lukesneeringer merged commit 5383505 into master Jun 27, 2020
@lukesneeringer lukesneeringer deleted the valid-ref branch June 27, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukesneeringer @noahdietz @googlebot